Approve Kanban board
ReemMohamedAbdelfatah opened this issue ยท comments
Hello Microverse๐,
We are two team members me and @Fahim-Khan-P.
This is the link to our project for the Kanban board (https://github.com/users/ReemMohamedAbdelfatah/projects/3/views/1)
have a good day!
Hi @Team
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted an issue, that does not have a link to the GitHub project(kanban board), please create a Github project using the template
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready ๐
Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
Thank you @prolajumokeoni I updated the link.
Hi @TEAM ๐
Good job so far working on the project requirements!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight ๐
No linter errors. โ๏ธ
GitHub flow is followed. โ๏ธ
Required Changes โป๏ธ
Check the comments under the review in the inline comments.
- For a team with two people - check if all cards with the Team3 prefix on the template were removed from students' copy of the template. Number of cards in Backlog should be equal to 17. But your cards in your Backlog equal 13 it would be nice if you corrected this.
Please use this template
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!๐๐๐
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi beautiful team ,
Good job so far!
May I highlight the following:
- The cards are distributed equaly.:heavy_check_mark:
- You implemented the changes required by the previous TSE:heavy_check_mark:
STATUS: APPROVED ๐ช๐
Congratulations! ๐
Your Kanban board is complete! You are ready to start working on your project
Optional suggestions
- Please check the comment under the review.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding! ๐ ๐ ๐
Feel free to leave any questions or comments in the PR thread and tag me @algerina if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
If anything seems to be unclear to you, reach out and ask anything by commenting on this Pull Request and mention me as Algerina, I will receive a notification and will respond.
Reviewed by Amel Khiri