All `/` in icon name replaced with `_` before regexps applied

Question

osipxd opened this issue 2 years ago · comments

We have icon with name icons / 24 / arrow back and I want to save it as n2_icon_arrow_back_24.xml
I've configured validate and replace patterns:

nameValidateRegexp: '^icons / (\d\d) / ([A-Za-z0-9 /_-]+)$'
nameReplaceRegexp: 'n2_icon_$2_$1'

Problem: Error: ❌ Bad asset name «icons _ 32 _ arrow back»
Workaround: Replace / in validatingRegexp to _ (why / replaced with _?)
```
nameValidateRegexp: '^icons _ (\d\d) _ ([A-Za-z0-9 /_-]+)$'
```
Problem: Error: The file “n_2_icon_arrow_back_32.xml” doesn’t exist. (why n_2 but not n2?)
Workaround: Haven't found. I've tried to remove n2 from nameReplaceRegexp, but the error is still here.

Daniil Subbotin · Answer 1 · Wed Feb 02 2022 15:09:37 GMT+0800 (China Standard Time)

FigmaExport automatically replaces symbol «/» with «_» before executing rexexps patterns because file name must not contains «/» symbol.
This is a bug. I will fix it.

Osip Fatkullin · Answer 2 · Wed Feb 02 2022 15:18:12 GMT+0800 (China Standard Time)

FigmaExport automatically replaces symbol «/» with «_» before executing rexexps patterns because file name must not contains «/» symbol.

Maybe will be better to replace symbols after nameReplaceRegexp is applied? I think it will be more intuitive.

Daniil Subbotin · Answer 3 · Wed Feb 02 2022 15:35:47 GMT+0800 (China Standard Time)

Maybe will be better to replace symbols after nameReplaceRegexp is applied? I think it will be more intuitive.

It will break backward compatibility. Every developer that use FigmaExport will need to update their regexps. This is not good.

I will fix 2-nd bug by the end of the week.
#145

Daniil Subbotin · Answer 4 · Thu Feb 03 2022 04:16:18 GMT+0800 (China Standard Time)

I've fixed the second bug. Please update to the latest version (0.31.7) and check again.

Osip Fatkullin · Answer 5 · Mon Feb 07 2022 14:51:30 GMT+0800 (China Standard Time)

I've fixed the second bug. Please update to the latest version (0.31.7) and check again.

Thanks, seems to be fixed.

Question about 1st problem. Is figma-export replaces only slashes / with underscores _?

Daniil Subbotin · Answer 6 · Mon Feb 07 2022 14:52:23 GMT+0800 (China Standard Time)

Is figma-export replaces only slashes / with underscores _?

Yep

Osip Fatkullin · Answer 7 · Mon Feb 07 2022 14:58:24 GMT+0800 (China Standard Time)

Yep

It would be great if this behavior will be documented

Daniil Subbotin · Answer 8 · Mon Feb 07 2022 14:59:18 GMT+0800 (China Standard Time)

I’ll update documentation.

Daniil Subbotin · Answer 9 · Tue Feb 08 2022 01:03:26 GMT+0800 (China Standard Time)

Added info about replacing "/" by "_" to CONFIG.md

Osip Fatkullin · Answer 10 · Tue Feb 08 2022 01:17:54 GMT+0800 (China Standard Time)

Thanks! I close this issue.