Drop virtual table

Question

Drop virtual table

siscia opened this issue 5 years ago · comments

Simone Mosciatti commented 5 years ago

Hi all,

I am thinking about dropping the virtual table from RediSQL, the one that are created with REDISQL_TABLES_BRUTE_HASH.

They are quite complex to maintain, and they don't bring too many benefits I believe.

Is somebody using them? How?

Somebody want to really keep them around?

At the beginning of August (2 weeks from now), if nobody complained, I will decide to drop those virtual table.

csnight · Answer 1 · Thu Jul 18 2019 14:12:14 GMT+0800 (China Standard Time)

It is useful when someone don't want to rewrite the records in redis by redisql , especially the number of records is very large. Remove this api means this people should write another db to run sql to protect the source data.

So, how about just keep it,if this doesn't affect any other APIs a lot

Simone Mosciatti · Answer 2 · Mon Aug 12 2019 14:30:53 GMT+0800 (China Standard Time)

I believe we are able to keep virtual tables!

Simone Mosciatti · Answer 3 · Tue Aug 20 2019 01:32:22 GMT+0800 (China Standard Time)

Unfortunately I wasn't able to retain virtual tables.

See #84

Still have to merge them, are there people actually using them?

Simone Mosciatti · Answer 4 · Tue Aug 20 2019 16:18:14 GMT+0800 (China Standard Time)

Before to actually drop them, I want to make sure that we will gain the expected capabilities of having multiple readers.