optional function parameters

[Andreas Mokros]

Do you handle optional function parameters in genphp7 or is this handles elsewhere?
There are these auto-generated nulls for missing parameters that are not so good for PHP.

[Aleksandr Kuzmenko]

function some (arg:Int = 1) {
}

Translated as

function some ($arg = 1) {
    if ($a === null) {
        $a = 1;
    }
}

So if you call some() Haxe generates expression some(null) and you get expected value $arg = 1 inside of a function.
However there is no way to check whether function was called without arguments or with null as argument.

[Andreas Mokros]

This is a problem for extern functions where you don't want to pass null quite often.

However there is no way to check whether function was called without arguments or with null as argument.

So the filling with nulls is done somewhere before in the compiler?

[Aleksandr Kuzmenko]

This is a problem for extern functions where you don't want to pass null quite often.

We can use externs overloading to avoid passing null for optional arguments: https://github.com/RealyUniqueName/haxe/blob/php7/std/php7/Global.hx#L83

So the filling with nulls is done somewhere before in the compiler?

Yes

[Andreas Mokros]

We can use externs overloading to avoid passing null for optional arguments

Yes, that's a workaround.

[Théo Sabattié]

Javascript does not generate null on call for optional parameters.
Why is there issue with php? Why isn't there way?

[Aleksandr Kuzmenko]

This is not the case anymore. It was a behavior inherited from old genphp.
There is a per-target config in compiler which i copy-pasted from old genphp. It has that option with null-arguments turned on. I turned it off for new generator and made corresponding changes in 5f296ab

[Aleksandr Kuzmenko]

I think, this issue can be closed now. Feel free to reopen if needed.

[Théo Sabattié]

Can you fix this issue for old genphp too? It will be great!

I tried to build haxe from your source to test, I got this error : "ocamlopt.opt: unknown option `-bin-annot'."
How can I fix that?

[Aleksandr Kuzmenko]

Can you fix this issue for old genphp too? It will be great!

I think it was added for purpose, so it might be unsafe to change it.

I tried to build haxe from your source to test, I got this error : "ocamlopt.opt: unknown option `-bin-annot'."

I don't know what is -bin-annot. It's probably something added by core team. Did you try with ocaml 4.0+?

[Théo Sabattié]

I think it was added for purpose, so it might be unsafe to change it.

That invokes issues for externs. Cannot that be a mistake?

I don't know what is -bin-annot. It's probably something added by core team. Did you try with ocaml 4.0+?

No, I will, thanks

[Andreas Mokros]

I needed tto install ocaml 4.02 to compile this fork.