Readify / TeamFlash

Build light driver for TeamCity + Delcom 904003 USB light

Home Page:https://tc.readifycloud.com/viewLog.html?buildTypeId=bt10&buildId=lastSuccessful&tab=artifacts&guest=1

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Marked as successful" builds are not treated as successful

mavadat opened this issue · comments

When build fails and user/admin uses "Mark as Successful..." under "Build Actions" TeamCity portal shows it as successful and green. However, build light wouldn't pick up the change and shows either Amber or Red depending on investigation status.

p.s. Pausing build is a valid work around in some cases but not always.

TeamCity question TW-24033 raised and shared in issue TW-2529

By design.

The build isn't proven green yet. Team still can't pull latest source.

Tatham Oddie
Tiny phone keyboard = tiny message

On 13/10/2012, at 19:20, "Jamal Mavadat" <notifications@github.commailto:notifications@github.com> wrote:

When build fails and user/admin uses "Mark as Successful..." under "Build Actions" TeamCity portal shows it as successful and green. However, build light wouldn't pick up the change and shows either Amber or Red depending on investigation status.

p.s. Pausing build is a valid work around in some cases but not always.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2.

Manually changing build status is a new feature for a reason, and of course shouldn't be abused: http://confluence.jetbrains.net/display/TCD7/Changing+Build+Status+Manually

In occasions where it makes sense to manually change build status TeamFlash not respecting the change feels buggy because it won't match to what TeamCity reports.

Oh, sorry. I read it as “Mark as fixed”, not “Mark as successful”.

Pull request welcomed. ;)

From: Jamal Mavadat [mailto:notifications@github.com]
Sent: Sunday, 14 October 2012 11:10
To: Readify/TeamFlash
Cc: Tatham Oddie
Subject: Re: [TeamFlash] "Marked as successful" builds are not treated as successful (#2)

Manually changing build status is a new feature for a reason, and of course shouldn't be abused: http://confluence.jetbrains.net/display/TCD7/Changing+Build+Status+Manually

In occasions where it makes sense to manually change build status TeamFlash not respecting the change feels buggy because it won't match to what TeamCity reports.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-9413786.

@tathamoddie once TeamCity's TW-24033 is closed I'll be working on this. :)

It sounds like it will get fixed automatically.

(As in, our code will just start working.)

As of TeamCity 7.1.2 TW-24305 is fixed. All good now.