ReactiveX / RxSwift

Reactive Programming in Swift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

visionOS Compiling Error

ilkerulusoy opened this issue · comments

Short description of the issue:

There is compiling error in RxCocoa/UIApplication+Rx.swift for visionOS SDK. There is a macro in the top of the code but not working.

Expected outcome:

Compile without error.

What actually happens:

in RxCocoa/UIApplication+Rx.swift
Application.isNetworkActivityIndicatorVisible is available in xrOS

CleanShot 2023-06-22 at 01 00 35@2x

in RxCocoa/UITabBar+Rx.swift
'tabBar(:willBeginCustomizing:)' is unavailable in xrOS
'tabBar(
:willEndCustomizing:changed:)' is unavailable in xrOS,

CleanShot 2023-06-22 at 01 43 24@2x

RxSwift/RxCocoa/RxBlocking/RxTest version/commit

RxCocoa/7d93271874a742595980a876f7328d958853d5c1

Platform/Environment

  • iOS
  • macOS
  • tvOS
  • watchOS
  • playgrounds
  • visionOS

How easy is to reproduce? (chances of successful reproduce after running the self contained code)

  • easy, 100% repro
  • sometimes, 10%-100%
  • hard, 2% - 10%
  • extremely hard, %0 - 2%

Xcode version:

Xcode 15 Beta 2

⚠️ Fields below are optional for general issues or in case those questions aren't related to your issue, but filling them out will increase the chances of getting your issue resolved. ⚠️

Installation method:

  • CocoaPods
  • Carthage
  • Git submodules

I have multiple versions of Xcode installed:
(so we can know if this is a potential cause of your issue)

  • yes (which ones)
  • no

Level of RxSwift knowledge:
(this is so we can understand your level of knowledge
and formulate the response in an appropriate manner)

  • just starting
  • I have a small code base
  • I have a significant code base

I think this PR is no longer valid since directive os(iOS) was incorrectly true for visionOS (e.g. in Beta 8 it is false). So I think the only changes needed for fixing compiling errors are in my #2542.

I will re-check