Giters

ReactiveX / RxSwift

Reactive Programming in Swift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Rename Cancelable -> Cancellable

kyungpyoda opened this issue · comments

commented

What do you think about changing Cancelable to Cancellable?
I know Cancelable is not wrong spelling and is preferred American English spelling.
But in RxJava, Combine and some other frameworks, it is named Cancellable.
I couldn't find any frameworks using Cancelable.

It will be a very wide change that touches most places in the code base.
I don't like to make a big change for a trivial renaming, but I still prefer Cancellable. 😅

Check PR #2414

commented

What do you think about changing Cancelable to Cancellable?

I know Cancelable is not wrong spelling and is preferred American English spelling.

But in RxJava, Combine and some other frameworks, it is named Cancellable.

I couldn't find any frameworks using Cancelable.

It will be a very wide change that touches most places in the code base.

I don't like to make a big change for a trivial renaming, but I still prefer Cancellable. 😅

Check PR #2414

Hey
I meant the issue should come before the big change and PR :)

Since you already opened the PR, let's keep the discussion there. I've already answered your question and it's not a change we could (or want to) make.

Thanks !