Implement mergeDelayError
bartvanhoutte opened this issue · comments
Bart Vanhoutte commented
Is there any way to implement mergeDelayError using the existing operators? If not, it would be very handy to have this operator.
Bart Vanhoutte commented
Something like this perhaps?
final class MergeDelayErrorOperator implements OperatorInterface
{
private ObservableInterface $subsequentObservable;
/**
* MergeDelayErrorOperator constructor.
*
* @param ObservableInterface $subsequentObservable
*/
public function __construct(ObservableInterface $subsequentObservable)
{
$this->subsequentObservable = $subsequentObservable;
}
public function __invoke(ObservableInterface $observable, ObserverInterface $observer): DisposableInterface
{
$errors = [];
return $observable
->materialize()
->merge($this->subsequentObservable->materialize())
->filter(static function ($event) use (&$errors) {
$class = get_class($event);
if ($class === OnErrorNotification::class) {
$errors[] = $event;
return false;
} elseif ($class === OnCompletedNotification::class) {
return false;
}
return true;
})
->dematerialize()
->subscribe(
[$observer, 'onNext'],
[$observer, 'onError'],
static function () use ($observer, &$errors) {
array_map(fn(Notification $n) => $n->accept($observer), $errors);
$observer->onCompleted();
}
);
}
}
Matt Bonneau commented
@bartvanhoutte I have tested a couple of ideas. Here is my preferred solution:
Observable::fromArray([$observable1, $observable2])
->reduce(function ($a, Observable $o) {
$s = new Subject();
return [
$a[0]->merge($o->catch(function (\Throwable $e) use ($s) {
$s->onError($e);
return Observable::empty();
})),
$a[1]->merge($s)
];
}, [Observable::empty(), Observable::empty()])
->flatMap(function ($a) {
return $a[0]->concat($a[1]);
});
Here it is implemented as a function in the Observable
class:
public function mergeDelayError(Observable $o) : Observable {
return Observable::fromArray([$this, $o])
->reduce(function ($a, Observable $o) {
$s = new Subject();
return [
$a[0]->merge($o->catch(function (\Throwable $e) use ($s) {
$s->onError($e);
return Observable::empty();
})),
$a[1]->merge($s)
];
}, [Observable::empty(), Observable::empty()])
->flatMap(function ($a) {
return $a[0]->concat($a[1]);
});
}
Below is a test of the solution:
<?php
namespace Rx\Functional\Operator;
use Rx\Functional\FunctionalTestCase;
use Rx\Observable;
use Rx\Subject\Subject;
class MergeDelayErrorTest extends FunctionalTestCase
{
/**
* @test
*/
public function it_waits_for_complete_before_emitting_error()
{
$xs = $this->createColdObservable(array(
onNext(100, 4),
onNext(200, 2),
onNext(300, 3),
onNext(400, 1),
onCompleted(500)
));
$ys = $this->createColdObservable(array(
onNext(50, 'foo'),
onNext(100, 'bar'),
onNext(150, 'baz'),
onError(160, new \Exception()),
onNext(200, 'qux'),
onCompleted(250)
));
$results = $this->scheduler->startWithCreate(function() use ($xs, $ys) {
$xs->mergeDelayError($ys);
});
$this->assertMessages(array(
onNext(250, 'foo'),
onNext(300, 4),
onNext(300, 'bar'),
onNext(350, 'baz'),
onNext(400, 2),
onNext(500, 3),
onNext(600, 1),
onError(700, new \Exception())
), $results->getMessages());
$this->assertSubscriptions(array(subscribe(200, 700)), $xs->getSubscriptions());
$this->assertSubscriptions(array(subscribe(200, 360)), $ys->getSubscriptions());
}
}