Crashed on Smart Key Path KVO when values are enums

Question

Crashed on Smart Key Path KVO when values are enums

wordlessj opened this issue 5 years ago · comments

Current implementations of producer(for:) and signal(for:) use old Objective-C API, which get values from value(forKey:). It works for most types except enums, value(forKey:) returns an NSNumber, then force-casted to the original enum type, which crashes. Maybe we should use Swift KVO API instead?

IKEDA Sho · Answer 1 · Thu Apr 11 2019 19:13:06 GMT+0800 (China Standard Time)

A good news is that is exactly #3491 which was merged recently.

Javier Zhang · Answer 2 · Fri Apr 12 2019 13:27:58 GMT+0800 (China Standard Time)

I may not have made It clear, this PR is the origin of the crash. It gets values from value(forKey:) which returns NSNumber for enums, then producer(for:) and signal(for:) force cast NSNumber to the specific enum type which will crash. If we use the Swift KVO api, values passed to the closure will be the correct type.

IKEDA Sho · Answer 3 · Wed May 29 2019 21:45:34 GMT+0800 (China Standard Time)

#3667 should had fixed this.