Issues `import`ing module

Question

Issues `import`ing module

axelav opened this issue 7 years ago · comments

I'm unable to import the module as shown in the docs & am failing to find any default export in the source code. I'm trying to pull this into a pretty straightforward app that began using create-react-app so I don't anticipate any compilation issues - I've been wrong before though :).

import Media from 'react-media' gives me an error: export 'default' (imported as 'Media') was not found in 'react-media'

If I require the module in the node cli, I don't see any default property there either.

> var x = require('react-media')
undefined
> x
{ [Function: Media]
  propTypes:
   { defaultMatches: { [Function: bound checkType] isRequired: [Function: bound checkType] },
     query: [Function: bound checkType],
     render: { [Function: bound checkType] isRequired: [Function: bound checkType] },
     children: { [Function: bound checkType] isRequired: [Function: bound checkType] },
     targetWindow: { [Function: bound checkType] isRequired: [Function: bound checkType] } },
  defaultProps: { defaultMatches: true },
  Media: [Circular] }

any ideas where I'm going wrong here?

Grady F. Persell · Answer 1 · Fri Feb 02 2018 04:24:39 GMT+0800 (China Standard Time)

This latest version broke our build. When we import react-media, we get

Uncaught TypeError: Cannot assign to read only property 'exports' of object '#'
at Object.<anonymous> (react-media.js:1100)

Doug McDonald · Answer 2 · Fri Feb 02 2018 04:25:07 GMT+0800 (China Standard Time)

I'm seeing the same thing as the OP but oddly wasn't seeing this a couple of days ago. I'm using 1.6.1 so will try upgrading to 1.7.0

EDIT: it was 1.7.0 which broke the import. I was using ^1.6.1 and npm installed if I revert to 1.6.1 things work ok

Grady F. Persell · Answer 3 · Fri Feb 02 2018 04:45:41 GMT+0800 (China Standard Time)

Same for us. 1.7.0 is broken but 1.6.1 works.

Michael Jackson · Answer 4 · Fri Feb 02 2018 05:55:38 GMT+0800 (China Standard Time)

Sorry for the inconveniences! 1.7.0 was a bad release. I've unpublished it so you should be alright for now.

Axel Anderson · Answer 5 · Fri Feb 02 2018 06:07:43 GMT+0800 (China Standard Time)

thanks for the prompt reply @mjackson. I'll give 1.6.1 a shot.

Michael Jackson · Answer 6 · Thu Feb 08 2018 13:34:10 GMT+0800 (China Standard Time)

@axelav I just released 1.8.0-rc.1 which should not have this issue. Please give it a shot and let me know how it goes!

npm install react-media@next

Axel Anderson · Answer 7 · Fri Feb 09 2018 00:47:49 GMT+0800 (China Standard Time)

@mjackson seems to have done the trick - thanks for the heads up!

Michael Jackson · Answer 8 · Fri Feb 09 2018 02:49:17 GMT+0800 (China Standard Time)

Thanks for the feedback, @axelav. Just released in 1.8.0.