Giters

ReSwift / GitHubBrowserExample

[WIP] Real World Example for ReSwift

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Credentials.swift not in repo

jschmid opened this issue · comments

commented

The Credentials.swift file is not committed in the repo, so the project does not compile.

Could you please provide a sample file?

commented

Thanks @jschmid for pointing this out! TIL that I had mistakenly untracked the file instead of just ignoring future updates to it.

Fixed with this commit: 5c79dfa

Let me know if that works for you!

commented

Thanks! It works now.

As a side not, I personally prefer this way to handle it:

  • Add "Credentials.swift" in .gitignore
  • Create a Credentials.sample.swift file that has the same content, without the API keys.
  • Document in the readme to copy the sample file into the "real" filename.

It has advantages:

  • If you change the file content, you can easily commit it again, not like with assume-unchanged
  • As a user, when you put your own credentials, you don't see the "real" file as changed, since it is ignored

That's my two cents 👍