Import with XCode 11 SwiftPackageManager doesn´t compile

Question

Import with XCode 11 SwiftPackageManager doesn´t compile

Chrichton opened this issue 5 years ago · comments

Hi Rastislav,
thank you so much for updating Package.Swift
The import via XCode 11/Swift Packages/Add Package Dependency now works. :-)

But unfortunately, I get 104 Compiler Errors.

The first one is:
//
// LimitedGestureViewDelegate.swift
// FlexColorPicker
//
// Created by Rastislav Mirek on 29/9/19.
//
// MIT License
// Copyright (c) 2018 Rastislav Mirek
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:

// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.

// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
//

public protocol LimitedGestureViewDelegate {
func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool
}
Use of undeclared type 'UIGestureRecognizer'

Am I doing something wrong?

Rastislav Mirek · Answer 1 · Tue Oct 08 2019 18:35:47 GMT+0800 (China Standard Time)

Hi Heiko, I am working on it. Give me 1 hour and try again. Let me know if it does not work after 1 hour. And sorry for the trouble. This is my bad. I will release 1.3.1. that should finally work.

Heiko Goes · Answer 2 · Tue Oct 08 2019 18:38:45 GMT+0800 (China Standard Time)

Thank you. You are doing great. I started using FlexColorControl since yesterday and suddenly I could use SPM. I am so lucky Viele Grüße von Heiko

…

Am 08.10.2019 um 12:35 schrieb Rastislav Mirek ***@***.***>: Hi Heiko, I am working on it. Give my 1 hour and try again. Let me know if it does not work after 1 hour. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Rastislav Mirek · Answer 3 · Tue Oct 08 2019 19:19:29 GMT+0800 (China Standard Time)

Ok, I might need more than 1 hour but you should have it fix by this evening

Rastislav Mirek · Answer 4 · Thu Oct 10 2019 00:55:43 GMT+0800 (China Standard Time)

Finally it's pushed, please try it now and let me know if it works. It's new version 1.3.1

Tim Bert · Answer 5 · Thu Oct 10 2019 01:24:25 GMT+0800 (China Standard Time)

Hi,

I got another error with 1.3.1

/var/folders/03/1cwvdlhj0kl0rgytrf0r2s4r0000gn/T/TemporaryFile.uvjtFa.swift:38:5: error: argument 'platforms' must precede argument 'products'
    platforms: [
~~~~^~~~~~~~~~~~

Rastislav Mirek · Answer 6 · Thu Oct 10 2019 01:25:30 GMT+0800 (China Standard Time)

Never ending story... Ok, fix comming right now.

Tim Bert · Answer 7 · Thu Oct 10 2019 01:31:32 GMT+0800 (China Standard Time)

Thanks. Please tag it such that the update can be picked up by SPM

Rastislav Mirek · Answer 8 · Thu Oct 10 2019 01:34:33 GMT+0800 (China Standard Time)

Sorry for the trouble... I have never dealt with SPM before, I am all old school Cocoapods guy. How does it look now? I expect couple of compile errors now but at least that would be step forward.

Tim Bert · Answer 9 · Thu Oct 10 2019 01:41:48 GMT+0800 (China Standard Time)

Much better. SPM trouble seems to be over now. Thanks.
But indeed there are compile errors:
import UIKit in LimitedGestureViewDelegate.swift, ColorPaleteControl.swift

Rastislav Mirek · Answer 10 · Thu Oct 10 2019 01:46:39 GMT+0800 (China Standard Time)

I can add the explicit UIKit import to LimitedGestureViewDelegate.swift but it is already in ColorPaleteControl... By any chance did you mean some other class?

Tim Bert · Answer 11 · Thu Oct 10 2019 01:51:55 GMT+0800 (China Standard Time)

No I see the use of undeclared type error in LimitedGestureViewDelegate.swift

Rastislav Mirek · Answer 12 · Thu Oct 10 2019 01:54:50 GMT+0800 (China Standard Time)

If that's the only compile error you see it should be fixed now. Please try again. And your help is very apreciated.

Tim Bert · Answer 13 · Thu Oct 10 2019 02:10:36 GMT+0800 (China Standard Time)

Unfortunately it is not the only compile error: I think this should help
In RectangularHSBPaletteDelegate.swift, CGPointExtension.swift and CGRectExtension.swift replace import Foundation by import UIKit

Rastislav Mirek · Answer 14 · Thu Oct 10 2019 02:45:35 GMT+0800 (China Standard Time)

I do not understand why SPM would need that but it's done. Please try now, finger crossed that it finally works.

Tim Bert · Answer 15 · Thu Oct 10 2019 02:58:47 GMT+0800 (China Standard Time)

Just 6 issues left. All of them should be done by replacing import Foundation by import UIKit in CGRectExtension.swift

Rastislav Mirek · Answer 16 · Thu Oct 10 2019 06:15:33 GMT+0800 (China Standard Time)

Changed the import. Are we there yet? Anybody else sees more errors?

Tim Bert · Answer 17 · Thu Oct 10 2019 10:40:31 GMT+0800 (China Standard Time)

It works now. No more error!! Migration to SPM is completed.
Thanks a lot @RastislavMirek

Heiko Goes · Answer 18 · Thu Oct 10 2019 12:31:11 GMT+0800 (China Standard Time)

Superb! Thanks a lot. Rastislav, if you like would you like to tell me, what you do professionally and how it you comes, you support such a nice Module for free. Best regards from Heiko

…

Am 10.10.2019 um 04:40 schrieb Tim Bert ***@***.***>: It works now. No more error!! Migration to SPM is completed. Thanks a lot @RastislavMirek <https://github.com/RastislavMirek> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#20?email_source=notifications&email_token=AAOPYG4QDIEOFH2WCOWPPULQN2I2BA5CNFSM4I6P6ILKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA2HDOA#issuecomment-540307896>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOPYG5QNH64HGGUFCA6EUDQN2I2BANCNFSM4I6P6ILA>.

Rastislav Mirek · Answer 19 · Thu Oct 10 2019 20:09:50 GMT+0800 (China Standard Time)

Superb! Thanks a lot. Rastislav, if you like would you like to tell me, what you do professionally and how it you comes, you support such a nice Module for free. Best regards from Heiko
…

Professionally, I develop made to order iOS and React apps. FlexColorPicker is spin-off from one of my personal projects (EasyType Keyboard). I support it because it is used and because there seems to be no alternative "hackable" color picker for Swift.