Dev branch: "Parse as PHP" option not properly closing PHP code
octagons opened this issue · comments
The listing below causes an uploaded file to include the string "<?php" at the end of the file if the "parse as PHP" option is selected for the file hosting action.
FiercePhish/app/HostedFile.php
Line 36 in c73d4ad
As a temporary workaround, I changed the line to the following:
eval('?> ' . $code . '<?php ?>');
This is clearly not a permanent solution, but it is unclear what functionality was originally intended in its current implementation.
I haven't had an issue here before yet, but that may be due to insufficient testing since its an early addition in the dev branch. Do you have an example PHP file you are hosting that I can test with?