[Issue]: Windows 5.7 SDK has broken CMake detection with hardcoded path and nonexistent amdhip64.dll

Question

[Issue]: Windows 5.7 SDK has broken CMake detection with hardcoded path and nonexistent amdhip64.dll

GZGavinZhao opened this issue 3 months ago · comments

Problem Description

The HIP 5.7 SDK for Windows cannot be used with CMake because it hardcodes some HIP import prefix as C:/constructicon/builds/gfx/two/23.30/drivers/compute/install/native/Release/x64/hip and tries to find a non-existent amdhip64.dll file in the SDK.

Operating System

Windows 11, will update exact version later, on linux right now

CPU

AMD Ryzen 7 5800H with Radeon Graphics

GPU

AMD Radeon VII

ROCm Version

ROCm 5.7.0

ROCm Component

No response

Steps to Reproduce

Install the ROCm 5.7 SDK for Windows with default settings: https://www.amd.com/en/developer/resources/rocm-hub/hip-sdk.html. This example uses the "Windows 10 & 11" version, but the "Windows Server" version has the same problem. All commands are run in Powershell.

Write a simple CMake file. This examples uses the native CMake support, but using the legacy target_link_libraries(MyLib PRIVATE hip::device) gives the same result.

cmake_minimum_required(VERSION 3.21) # HIP language support requires 3.21
cmake_policy(VERSION 3.21.3...3.27)
project(MyProj LANGUAGES HIP)
add_executable(vectoradd_hip vectoradd_hip.cpp)
set_source_files_properties(vectoradd_hip.cpp PROPERTIES LANGUAGE HIP)

Create a file at vectoradd_hip.cpp. I just used https://github.com/ROCm/HIP-Examples/blob/master/vectorAdd/vectoradd_hip.cpp.
Run cmake -GNinja -B build -S . -DCMAKE_PREFIX_PATH="C:/Program Files/AMD/ROCm/5.7. If CMake claims that it can't find a valid HIP compiler, run $env:Path = "C:\Program Files\AMD\ROCm\5.7;$env:Path" prior to executing CMake.
Now you should see an error message, claiming that the file C:/constructicon/builds/gfx/two/23.30/drivers/compute/install/native/Release/x64/hip/lib/amdhip64.lib is not found. This shouldn't happen.

error message

CMake Error at C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-targets.cmake:82 (message):
  The imported target "hip-lang::amdhip64" references the file

     "C:/constructicon/builds/gfx/two/23.30/drivers/compute/install/native/Release/x64/hip/lib/amdhip64.lib"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-config.cmake:87 (include)
  C:/Program Files/CMake/share/cmake-3.29/Modules/CMakeHIPInformation.cmake:159 (find_package)
  CMakeLists.txt:3 (project)


CMake Debug Log at C:/Program Files/CMake/share/cmake-3.29/Modules/CMakeHIPInformation.cmake:159 (find_package):
    C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-langConfig.cmake
    C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-config.cmake

Call Stack (most recent call first):
  CMakeLists.txt:3 (project)


-- Configuring incomplete, errors occurred!

Now, (might need admin privileges), go edit C:\Program Files\AMD\ROCm\5.7\lib\cmake\hip-lang\hip-lang-targets.cmake. You'll see that line 45 has set(_IMPORT_PREFIX "C:/constructicon/builds/gfx/two/23.30/drivers/compute/install/native/Release/x64/hip"). Replace that with set(_IMPORT_PREFIX "C:/Program Files/AMD/ROCm/5.7"), and run the CMake command in step 3 again.
Now you should get a different error, claiming that CMake fails to find amdhip64.dll, but that file is not present anywhere in C:/Program Files/AMD/ROCm/5.7:

error message

CMake Error at C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-targets.cmake:83 (message):
  The imported target "hip-lang::amdhip64" references the file

     "C:/Program Files/AMD/ROCm/5.7/bin/amdhip64.dll"

  but this file does not exist.  Possible reasons include:

  * The file was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and contained

     "C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-targets.cmake"

  but not all the files it references.

Call Stack (most recent call first):
  C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-config.cmake:87 (include)
  C:/Program Files/CMake/share/cmake-3.29/Modules/CMakeHIPInformation.cmake:159 (find_package)
  CMakeLists.txt:3 (project)


CMake Debug Log at C:/Program Files/CMake/share/cmake-3.29/Modules/CMakeHIPInformation.cmake:159 (find_package):
    C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-langConfig.cmake
    C:/Program Files/AMD/ROCm/5.7/lib/cmake/hip-lang/hip-lang-config.cmake

Call Stack (most recent call first):
  CMakeLists.txt:3 (project)


-- Configuring incomplete, errors occurred!

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

Adam Tran - AMD · Answer 1 · Thu Apr 04 2024 22:13:24 GMT+0800 (China Standard Time)

An internal ticket has been created for investigation.

YellowRoseCx · Answer 2 · Sat Apr 13 2024 03:41:05 GMT+0800 (China Standard Time)

try using find_package(hip) instead of setting the language to HIP

Garden_eel · Answer 3 · Sun Apr 28 2024 09:52:42 GMT+0800 (China Standard Time)

try using find_package(hip) instead of setting the language to HIP尝试使用 find_package(hip) 而不是将语言设置为 HIP

Is that a practiced method? I tried to follow the ROCm-examples building guide
but also met the same problem, therefore I don't think find_package(hip) is an official practice. Did you try it?

YellowRoseCx · Answer 4 · Wed May 01 2024 22:57:58 GMT+0800 (China Standard Time)

try using find_package(hip) instead of setting the language to HIP尝试使用 find_package(hip) 而不是将语言设置为 HIP

Is that a practiced method? I tried to follow the ROCm-examples building guide but also met the same problem, therefore I don't think find_package(hip) is an official practice. Did you try it?

When I would set my "LANGUAGE" to HIP in my CMake file, I would get the same/similar error. In my current project, I use

find_package(hip)
find_package(hipblas)
find_package(rocblas)

to make it build on Windows
https://github.com/YellowRoseCx/koboldcpp-rocm/blob/4a3626eebf36565e93b3d5f79ebbcfdcbb815d97/CMakeLists.txt#L151C1-L153C26

It's also briefly mentioned in the ROCm Documentation here:
https://rocm.docs.amd.com/en/latest/conceptual/cmake-packages.html#consuming-the-hip-api-in-c-code