RJHsiao / ListOpenedTabs

An Google Chrome extension for list, search, rearrange, close tabs and switch to another tab.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

add badge to show tab count

insaner opened this issue · comments

Hi, it would be great to add a badge to the button in order to show the tab count for the current window. Fortunately, I already wrote the code for this, and have added it to my fork. Let me know how you would like me to proceed.

Hi @insaner
Thanks for your suggestion!
I think create a pull request will very helpful for me if you already coding for that. 👍

Great! I'm not very familiar with how to do things in github as I rarely use it, but I will try to do that. Let me know if I did it right.

I'm so sorry if I flooded your inbox/notifications (does github send notifications about forks?) while I was figuring out how to put the code up, remove any unnecessary code, etc, before the pull request. Please do let me know if I did it right, and everything is ok.

Sorry to reply too late, and never mind about my inbox.
I'll review your PR ASAP.
Thanks for your contribution. 👍

My pleasure! Sorry again if you did get a bunch of notifications, (did you?) I'm still figuring this whole github thing out. Let me know what you think of the changes, and thanks again for the great work!

Hi, any updates? Does the commit look ok?

Hi @insaner
Thanks for your PR.
I already reviewed the code and left some comments.
Please try to resolve them, thank you :)

Will do, thanks!

Well done!
I'll release new version ASAP.

@insaner
New version released, thanks for your contribution.