Pool#ping has weird semantics
erikh opened this issue · comments
(Thanks to raggi)
It's arguable that RDBI::Pool#ping's semantics could be a little clearer. Do we want the average ping of all the handles, the connected ones only, do we want to weight the average.. Do we want to communicate times at all?
I made a minor patch just to make the code more clear, but I think a doc patch is all that's missing now, maybe just say "Weighted Average" - in general just describe the return type / intent, other than a keepalive.
Ok, I'm still not sure I like it, maybe a second call called "up" or something that's just a boolean result might be a good idea.
Added RDBI::Pool#up which should make this a little better.