Nuget should buildTransitive instead of build for the QuestPDF.targets
165plo opened this issue · comments
Describe the bug
When consuming QuestPDF in a .netstandard library (that will later the consumed by a .net4.8 application) the QuestPDF.targets file is not passed all the way through to the .net4.8 application. The .target is only present in the .netstandard library bin and the native libraries (QuestPdfSkia.dll) are then unable to be found.
To Reproduce
Please provide an example, minimalistic code that shows the problem.
Providing working example or example repository greatly helps us investigate the problem and react faster.
This can be reproduced by creating a .netstandard library that uses QuestPDF and a .Net Framework 4.8 application that uses the .netstandard library.
Expected behavior
A clear and concise description of what you expected to happen.
The target is applied to the .Net Framework 4.8 application and the QuestPDF.targets is available to reference the QuestPdfSkia.dll
Screenshots
If applicable, add screenshots to help explain your problem.
Here is a screenshot of the QuestPDF nuget.
Here is a screenshot of SkiaSharp where the issue doesn't exist and buildTransitive is being used.
Environment
What version of the library do you use?
2024.3.0
What operating system do you use? (OS type, x64 vs x86 vs arm64)
Windows x64
Additional context
Add any other context about the problem here.
Based on the main repo it looks like the change would be as simple as change the folder name
Source/QuestPDF/Build/net4
to
Source/QuestPDF/buildTransitive/net4
Is there a procedure for me to be able to contribute to the repo?
Thank you for sharing your experience and this particular problem 😄
A couple of weeks ago, I tried to use the buildTransitive folder (similar to SkiaSharp) but observed that certain nuget artifacts are missing. Since then, I have learned a lot. I will try replacing the build folder with buildTransitive. If everything works well, the new release will be published soon.