Quantco / tabmat

Efficient matrix representations for working with tabular data

Home Page:https://tabmat.readthedocs.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug with StandardizedMatrix transpose matvec

MarcAntoineSchmidtQC opened this issue · comments

Our testing unfortunately did not cover the scaled StandardizedMatrix case due to a typo.
(we tested the centered but unscaled StandardizedMatrix twice)
https://github.com/Quantco/quantcore.matrix/blob/master/tests/test_matrices.py#L95-L100

Correcting this, the test test_transpose_matvec_out_parameter is failing with all the new matrices.

Preliminary investigation: I think this is more likely to be a bug with the test itself.

Is this issue still an issue after #94?

Thanks for pointing that out. No it's not.