Add json to project includes

Question

palucki opened this issue 7 years ago · comments

It can be used as subrepo / submodule or downloaded directly to project.

Filip Kubicz · Answer 1 · Sat Oct 14 2017 03:44:42 GMT+0800 (China Standard Time)

Do you mean json files with Hu moments?

Piotr Pałucki · Answer 2 · Sat Oct 14 2017 04:10:17 GMT+0800 (China Standard Time)

Json.hpp only ;)

On Oct 13, 2017 21:44, "Filip Kubicz" ***@***.***> wrote: Do you mean json files with Hu moments? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG9_DmkK3lB2brk0a0LFpIm318ELS0MFks5sr72qgaJpZM4P15at> .

Filip Kubicz · Answer 3 · Sat Oct 14 2017 04:39:18 GMT+0800 (China Standard Time)

Then I'm for having it as a submodule ;)

Filip Kubicz · Answer 4 · Sat Oct 14 2017 04:44:12 GMT+0800 (China Standard Time)

Piotr Pałucki · Answer 5 · Wed Oct 18 2017 02:41:50 GMT+0800 (China Standard Time)

Submodule is evil: https://codingkilledthecat.wordpress.com/2012/04/28/why-your-company-shouldnt-use-git-submodules/
Added as a subtree.
Added with command:
git subtree add --prefix PC/svm/json https://github.com/nlohmann/json.git master --squash
It requires a lot of unnecessary code (tests, doc etc.)
Finally decided to add only raw file in "includes" dir

Filip Kubicz · Answer 6 · Wed Oct 18 2017 03:05:56 GMT+0800 (China Standard Time)

Yeah, I've seen some issues with submodules recently ;) If there is too much overhead, raw file is OK. Thanks!

So in this workflow what we will need to do is to pull the updated version of the library file manually when the new release arrives.