_PUTIMAGE option adjust image but maintain 1:1 aspect ratio

[Richard]

Currently

If the area of the source is bigger or smaller than the area of the
destination then the image is adjusted to fit that area.

However the aspect ratio is not preserved.

Feature request - option to adjust image to fit the destination but also maintain 1:1 aspect ratio.

[Kit]

Like a streamlined way of doing _PutImage (DestX1, DestY1)-(DestX2, DestY2), source, dest, (0, 0)-Step(_Width(source), _Height(source))?

[Deleted user]

Like a streamlined way of doing _PutImage (DestX1, DestY1)-(DestX2, DestY2), source, dest, (0, 0)-Step(_Width(source), _Height(source))?

I see no difference visually when using your code example and this from the Wiki:
_PUTIMAGE , sourceHandle&, destHandle& 'size full source to fit full destination area

[Kit]

Oh, my bad! I thought you wanted to crop the image.

To simply put the full image to a portion of the destination keeping a 1:1 aspect, you use _PutImage (destx, desty)-Step(_Width(source), _Height(Source)), source, dest

[Deleted user]

@richardFK Please advise if the above code snippets are what you are hoping to achieve.

[Richard]

Below is relevant code (written about a year ago - not looked at since) which I wanted to "improve upon" - in this case it would place a "rectangle image" (tall or wide) into a "square destination". The whole image is displayed (no cropping) and 1:1 aspect ratio is kept.

As my computer just "froze up to have only a black screen" (and could not recover) - I will have to spend a number of hours sorting out what I can manually recover from a continuous 3-day run. It may have nothing to do with QB64 - but ever since I started using QB64 v1.5 stable release, I always get a black screen after say a 1-2 day continuous run of my QB64 programs (of course my bet is it is a Windows 10 problem!)

        pic% = 256            ' size of square destination
        h& = _LOADIMAGE(img$)
        ymax! = _HEIGHT(h&)
        xmax! = _WIDTH(h&)
        
        IF xmax! > ymax! THEN
            x1% = x0% + pic%: y1% = y0% + pic% * (ymax! / xmax!)
        ELSE
            x1% = x0% + pic% * (xmax! / ymax!): y1% = y0% + pic%
        END IF
    
    _PUTIMAGE (x0%, y0%)-(x1%, y1%), img& 

and off course elsewhere in program h& handle check and _FREEIMAGE

Hopefully get back to you in 2 days time.

[Deleted user]

As my computer just "froze up to have only a black screen" (and could not recover) - I will have to spend a number of hours sorting out what I can manually recover from a continuous 3-day run. It may have nothing to do with QB64 - but ever since I started using QB64 v1.5 stable release, I always get a black screen after say a 1-2 day continuous run of my QB64 programs (of course my bet is it is a Windows 10 problem!)

I'm willing to bet that it is more likely a problem with your code causing too much memory usage due to a leak or an ever-increasing string. I would recommend that you go through your code. I would also recommend that you either join our Discord server or the forum and ask questions there. There are many users and you will be able to receive help quickly.

[Richard]

Re "possible memory leak or growing strings". My programs were essentially written and completed by me over a year ago, and for the first few weeks I had trouble with memory leaks (until Steve "put me right" re handles etc). So, for about 3 months since the "fix up" I had closely monitored, using Task Manager, on memory useage. Out of 32 GByte RAM, 22 GByte is allocated for "Windows use". About a month ago, I "caught a culprit" 3rd party app that mysteriously jumped from about 200 MByte memory to over 2 GByte memory and a few hours afterwards the black screen occurred. That 3rd party app has been since discontinued use by me. My long duration run (over a day) programs have clocked up say 2000-5000 hours each spread over about 100 or so starts. For about a year there was no memory leak creepage (according to Task Manager) - I probably viewed Task Manager over a thousand times just solely to monitor my programs. Specific potential problems eg from say _PUTIMAGE (used well over 10 million times collectively) I feel are ruled out. Also, any errors (from error pop-ups) relating to _PUTIMAGE etc stopped occurring for me over a year ago (for these same programs). Thank you for your suggestions anyway - much appreciated.

…

________________________________ From: Zachary Spriggs ***@***.***> Sent: Saturday, 3 April 2021 5:05 AM To: QB64Team/qb64 ***@***.***> Cc: richardFK ***@***.***>; Mention ***@***.***> Subject: Re: [QB64Team/qb64] _PUTIMAGE option adjust image but maintain 1:1 aspect ratio (#161) As my computer just "froze up to have only a black screen" (and could not recover) - I will have to spend a number of hours sorting out what I can manually recover from a continuous 3-day run. It may have nothing to do with QB64 - but ever since I started using QB64 v1.5 stable release, I always get a black screen after say a 1-2 day continuous run of my QB64 programs (of course my bet is it is a Windows 10 problem!) I'm willing to bet that it is more likely a problem with your code causing too much memory usage due to a leak or an ever-increasing string. I'd recommend that you go through your code. I'd recommend that you either join our Discord server or the forum and ask questions there. There are many users and you will be able to receive help quickly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#161 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHCH57KIWDX2T3TKBJLU4GTTGYBPNANCNFSM42IRBKXQ>.

[Fellippe Heitor]

This seems like it'd be better served by a user-defined function. Closing for now (#wontfix).