Weak Password Creation
KhyalKara opened this issue · comments
Description
The script python-password-generator.py uses random.sample to pick unique characters, without allowing repetition of characters.
In short the number of possible passwords is greatly reduced
Proposed Fix:
# Instead Use:
random.choices(total, k=length)
Type of issue
- Bug
Checklist:
-
I have read the project guidelines.
-
I have checked all the existing projects, before submitting a new project issue.
-
I have checked previous issues to avoid duplicates.
-
This issue will be meaningful for the project.
-
I have added screenshots of the bug
-
I have added steps to reproduce the bug
-
I have proposed a possible solution for the bug