Pulsar-Edit-Highlights / selected

@Pulsar-Edit package for highlighting occurrences of your selection.

Home Page:https://web.pulsar-edit.dev/packages/highlight-selected

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Some words are not highlighted when selected in large files

KyLeggiero opened this issue · comments

commented

[Enter steps to reproduce:]

  1. Load a large file (My test is 10MB)
  2. Select a highlightable word

Atom: 1.36.1 x64
Electron: 2.0.18
OS: Mac OS X 10.13.6
highlight-selected: 0.16.0
Demonstration video: https://photos.app.goo.gl/Au1vY9cbvBDw5Yi68

Non-Core Packages

atom-material-syntax 1.0.8 
atom-material-syntax-dark 1.0.0 
atom-material-ui 2.1.3 
busy-signal 2.0.1 
highlight-selected 0.16.0 
intentions 1.1.5 
language-log 1.10.1 
language-swift 0.5.0 
linter 2.3.0 
linter-ui-default 1.7.1 
minimap 4.29.9 
minimap-bookmarks 0.4.2 
minimap-cursorline 0.2.0 
minimap-find-and-replace 4.5.2 
minimap-highlight-selected 4.6.1 
minimap-linter 2.2.1 
minimap-pigments 0.2.2 
minimap-selection 4.5.0 
Sublime-Style-Column-Selection 1.7.5 

Do you have the status bar enabled? If so you can easily see how many highlights have been added.

There's a setting that limits the number of highlights Maximum Highlights which is defaulted to 500.

See #193 for motivation.

This makes the plugin essentially useless for too large files. There should be an option to search for occurrences only inside currently visible section of the file being edited.