Consider migrating to the compression built into zlib

Question

Consider migrating to the compression built into zlib

nathanpeck opened this issue 4 years ago · comments

This package still uses iltorb, which is no longer needed in modern versions of Node:

npm WARN deprecated iltorb@2.4.3: The zlib module provides APIs for brotli compression/decompression starting with Node.js v10.16.0, please use it over iltorb

Regev Brody · Answer 1 · Wed Apr 08 2020 06:03:46 GMT+0800 (China Standard Time)

Thanks for the issue submission. I want to support node 6 and above, so I can't remove iltorb as a dependency. Would you mind making a pr that will try to use zlib only if applicable?

Regev Brody · Answer 2 · Wed Apr 08 2020 06:09:28 GMT+0800 (China Standard Time)

npm/npm#7340 there is an idea there on how to install conditional dependencies

Regev Brody · Answer 3 · Wed Apr 08 2020 06:21:51 GMT+0800 (China Standard Time)

https://stackoverflow.com/questions/44956778/conditional-postinstall-in-package-json-depending-on-your-os there ia an idea here as well

Regev Brody · Answer 4 · Sat Apr 11 2020 01:51:33 GMT+0800 (China Standard Time)

@nathanpeck released in 4.1.0

Nathan Peck · Answer 5 · Sat Apr 11 2020 09:57:24 GMT+0800 (China Standard Time)

Awesome! Massive thanks for the fast turnaround time on that! I was planning to PR but you beat me to it hah

…

On Fri, Apr 10, 2020 at 1:51 PM Regev Brody ***@***.***> wrote: @nathanpeck <https://github.com/nathanpeck> released in 4.1.0 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2VN6WQLXE2OLG723VNAKTRL5MDFANCNFSM4MDOU3CA> .

Regev Brody · Answer 6 · Sat Apr 11 2020 17:38:27 GMT+0800 (China Standard Time)

Haha you didn't respond so i figured you didn't have the time.
Glad to help!
If you like the library, a star would be much appreciated