Using your library in Network Skins!
boformer opened this issue · comments
Hey PropaneDragon,
just wanted to tell you that your library is used in Network Skins:
https://github.com/boformer/NetworkSkins
Right now I'm only loading the sprite loading functionality, but I plan to change that in the future.
Oh nice! I didn't expect anyone to find it just yet hehe, but it's almost finished anyway. I can't remember what I have left to do on it, as I've not been home in a while but I'll make an official release some time soon. Thanks for using it!
Oh one note: I'm not sure on the saving/loading from serialised data just yet as it hasn't been fully tested, so I'd avoid that for now. Saving and loading from disk for settings should be fine though.
Some things:
- Log calls still say "Road Namer": https://github.com/PropaneDragon/CimTools/blob/master/CimTools/Utilities/SpriteUtilities.cs#L84-L94
- This will not work if multiple mods call it: https://github.com/PropaneDragon/CimTools/blob/master/CimTools/File/Path.cs#L11
Thanks. I probably haven't got around to renaming that section yet as I've just been pulling it out and commenting it for documentation. Thanks for pointing out that bit of code. I didn't even consider that might be a problem and I'll get it changed as quick as I can.
With regards to the first issue: I think I've already changed the name but haven't pushed the changes yet. I'll have to wait until I get back home to sort it out, which should be around the 10th.
With regards to the second issue: I've used static a lot without realising sharing issues, so I'll be changing that around. I'm too used to C++ it seems.