Preston-Landers / concurrent-log-handler

fork of ConcurrentLogHandler

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Platform detection logic is flawed

buddly27 opened this issue · comments

"win" is also in "darwin", so the installation is requiring "pywin32" on macOS
https://github.com/Preston-Landers/concurrent-log-handler/blob/master/setup.py#L61

A safer way to detect the platform would be:

if sys.platform.startswith("win"):
    ...

Thanks for the PR!