PrefectHQ / prefect-dbt

Collection of Prefect integrations for working with dbt with your Prefect flows.

Home Page:https://prefecthq.github.io/prefect-dbt/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

GlobalConfigs' "log_format" should be of type String instead of Bool.

MohammedSiddiqui opened this issue · comments

Running dbt debug from the CLI task with GlobalConfigs generated throws an error that log_format should be of type String and not bool.
On the other hand, setting a string value via GlobalConfigs throws an error that it should be of type bool.

log_format: Optional[bool] = None

Thanks for the report; I've verified that it should be a string: https://docs.getdbt.com/reference/global-configs#log-formatting

Would you be interested in contributing a PR that changes this into:
log_format: Optional[str] = None and adding a simple test to test instantiating GlobalConfigs with log format set?

More about contributing a PR here.

Absolutely, let me look into this and I'll ping back if I face any issues setting up the development env

Thanks!