Giters

Postleaf / postleaf

Simple, beautiful publishing with Node.js.

Home Page:https://www.postleaf.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade to Bootstrap 4.0.0 stable

emmastone9 opened this issue · comments

commented

Summary

gulp build throws error

Steps to Reproduce

Trying to install Postleaf on my mac,
git clone https://github.com/Postleaf/postleaf.git
git clone https://github.com/Postleaf/empower-theme.git themes/empower-theme

Copied .env.example to .env and added localhost

npm install
sudo npm install -g gulp-cli

gulp build
returns:
[14:59:55] Finished 'build' after 118 μs
node_modules/bootstrap/scss/_variables.scss
Error: no mixin named -assert-ascending

   Backtrace:
   	node_modules/bootstrap/scss/_variables.scss:175
    on line 175 of node_modules/bootstrap/scss/_variables.scss

@include _assert-ascending($grid-breakpoints, "$grid-breakpoints");
---------^

Additional info

  • Postleaf version: latest
  • Node version: 7.9.0
  • Affected browsers: n/a
  • Operating system: mac

Note: This issue tracker is ONLY for bug reports and feature requests. If this is a personal support issue, please visit postleaf.org/support.

commented

I belive this is happening because Bootstrap is now stable. There were a few API changes from BS4 alpha to stable, so updates need to be made. Until then, try locking in 4.0.0-alpha.6 in your package.json.

commented

@claviska
locking in == commenting out?

I have the following line in package.json
"bootstrap": "^4.0.0-alpha.6",
However,
gulp build still returns the same error.

commented
commented

Thanks. That fixed the issue.. There's one more problem:
When running on port other than 80, default 3000
http://localhost/assets/css/lib.css returns 404

All other CSS/JS includes return 200.

commented