Compatibility Issues Between "React" and "React-OnClickOutside" Libraries.
OrMeirchak opened this issue · comments
Our project currently has 'react-onclickoutside': '^6.7.0' installed.
We recently updated our project from 'react': '^16.2.0' to 'react': '^18.2.0'.
However, we have encountered an issue with a component that is wrapped in onClickOutside.
After upgrading to the new version of React, the handleClickOutside function is called immediately after the component is created, without the user performing any action.
When we rolled back to 'react': '^16.2.0', the problem was resolved.
We would like to know if there is a version of 'react-onclickoutside' that is supported by 'react': '^18.2.0'?
I assume you kept the class notation rather than rewriting things to functions with hooks, like the React folks have been pushing for since 16.5?
Hi Pomax,
Thank you for your reply.
I am working on a large project that has been in development for many years. As a result, a significant portion of our components are still written using class notation.
Thanks, just wanted to make sure. I don't suppose you have a small self-contained example that can be dropped into the issue for testing?
Hi pomax , thank you very much for your willingness to help.
Unfortunately, I was not able to create an example that I could share.
After a long time of debugging, I noticed that during the creation of the wrapped component, it is registered to the event in this line:
document.addEventListener(eventName, handlersMap[this._uid], getEventHandlerOptions(this, eventName));
And immediately after that, the handlersMap function is activated. (The wrapped component is created by clicking on the screen that creates the event)
This is a behavior that also occurs in the old version of React, but for some reason, the event does not happen for the component that was just registered.
Thanks,or
Remember that an example doesn't need to be "your code". If you're seeing it do the wrong thing, it should be possible to create a standalone "new code" setup with a few dummy components that shows things going wrong. (because if you can't, there aren't really any steps to reproduce the problem, which means we can't make a test case)
Hi Pomax,
I've found a solution to the problem. In the constructor of the wrapped component, I save an initTimeStamp.
Then, every time before I execute the logic of the handleClickOutside function in the wrapped component, I check if the timeStamp of the event is greater than the initTimeStamp.
Do you now understand better what is causing the problem, or would you like me to try to create a pull request?"
Anyway, I created a pr
hm, I don't see a PR in the open PR list?
hm, I don't see a PR in the open PR list?
Im also facing the same issue. Was working fine for React 16.x, migration to 18.2 causes the issue. Im using Class components.
I'm going to have to point at https://react.dev/reference/react/Component at this point though.
Class components are still supported by React, but we don’t recommend using them in new code.
React went all in on functional components and hooks, whether we like it or not (I sure don't, the amount of horrible code that hooks gave rise to is truly staggering). There is just no point in trying to fight that, and functional components don't need this HoC anymore.
And I'd be very surprised if they don't flat out remove the Component class in React 19 or 20.
published v6.13.1, but I will reiterate here that if a project relied on this HoC enough for this PR to still be merged in: please read the first paragraph of the README.md and see what you can do.