Pomax / react-onclickoutside

An onClickOutside wrapper for React components

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No reaction on disableOnClickOutside property change

todesstoss opened this issue · comments

Hello, It seems that after last update i should explicitly call enableOnClickOutside method to enable functionality if initially disableOnClickOutside property was false.
It's not the way it used to work before and this change breaks my code.

I think methods enableOnClickOutside/disableOnClickOutside should be called in componentDidUpdate hook on disableOnClickOutside prop change.

I can prepare PR if you don't mind.

Thanks in advance.