PolyMC / PolyMC

A custom launcher for Minecraft that allows you to easily manage multiple installations of Minecraft at once (Fork of MultiMC)

Home Page:https://polymc.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Instance Storage Tab uses hard to read font color on dark theme

treacherousfiend opened this issue · comments

Operating System

Windows

Version of PolyMC

PolyMC 5.1

Version of Qt

QT 6.4.2

Description of bug

The storage tab on instances uses a very dark gray color for the storage percentages on the "Dark" theme
image

Only seems noticeable on the "Dark" theme

Steps to reproduce

  • Set PolyMC theme to "Dark"
  • Open Instance menu and go to the "Storage" tab
  • Strain your eyes to read percentages

Suspected cause

Something I noticed is that on the "Bright" theme, the non-bugged text on this tab seems to use a font color that's around hex 111111
image

the bugged text uses hex 404044
image
and it seems to keep the exact same color no matter what theme you use
image

I assume the intent was to use a slightly more subdued color than the rest of the text, but it unfortunately doesn't seem to take into account the theme. I also don't see that color defined anywhere in the code, so I wouldn't be surprised if its unintentional and just default QT behavior.
I'm not super familiar with QT, but i noticed that the m_chart member in launcher/ui/pages/instance/StoragePage.cpp never sets the theme that the chart should use? Maybe thats the issue?

This issue is unique

  • I have searched the issue tracker and did not find an issue describing my bug.

my bad bro will fix when i can, its qt default behavior