[RFC] Formatting Conventions
binex-dsk opened this issue · comments
Goal
Based on #1509
Now that PolyMC has diverged from Prism and MultiMC, there is no longer a need to keep backwards compatibility with either codebase. PolyMC needs to establish conventions for how we format our code.
Motivation
The PolyMC code is generally well put together, but many different developers have different standards for how they format stuff. In order to keep parity within code, we need to keep everything formatted identically.
Specification
Provide a strict set of standards for all things formatting. How we handle references and pointers, newline spacing, and more.
Drawbacks
It's impossible to force everyone to always go by the same standards. A random document on GitHub won't suffice.
Unresolved Questions
Should we adopt clang-format as our standard formatter?
How should we ensure every contributor sets up clang-format the same way?
Alternatives Considered
Simply running clang-format and having everyone follow whatever it does. See #1509.
This suggestion is unique
- I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.
You may use the editor below to elaborate further.
No response
idk just throw the default clang format config in lol
No