Giters

Poeschl / Hassio-Addons

The repository for my Home Assistant Supervisor Add-ons.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reinstate mitmproxy

davet2001 opened this issue · comments

commented

Which addon?

Mitmproxy

Is your feature request related to a problem? Please describe.

Feature request

Describe the solution you'd like

Un-deprecate the addon

Describe alternatives you've considered

Creating the an mitmproxy addon myself from scratch

Additional context

Mitmproxy is great for adblocking :)

commented

Hi, there.

Note: The MITM Proxy addon is depreciated and will not recieve any updates.

This is an automated comment. Responding to the bot or mentioning it won't have any effect.

commented

I'd really love for mitmproxy to be available again, and it seems that you are the only one that's made an addon for it. Perhaps I could help by submitting some PRs to get it up and running again? Please let me know your thoughts.

commented

Since reinstating the mitmproxy addon has a hight effort for myself, for only a little use, this will not happen. Sry, but it's an hobby and I'm already short on time for the other add-ons. 😅

If you want to revive it, fork the sources and maintain it yourself 😉

commented

Ok understood - that is totally fine.

Probably I cannot do a conventional fork because I would add it to my own repo with existing things in it, but would copy paste and reference back. Are you ok with that?

commented

@davet2001 That's totally fine 😊
When you give me a link, I will add it in the Readme here as well.

commented

hi @davet2001 , have you forked? I would like to add to my HA too.

commented

hi @davet2001 , have you forked? I would like to add to my HA too.

In progress, not ready yet!

commented

@Poeschl I have it mostly working, but I have a question: what is the reverse proxy for in the addon? I removed this and found it worked ok, directly exposing port 8080 for the regular webproxy, and port 8081 for the web configuration page.

I couldn't work out why the reverse proxy had been included. Please could you help me understand?

commented

I can only assume :)
It seems that the proxy was overwriting the X-Frame-Header to allow the web ui be shown from inside Home Assistant.

commented

Ok, thanks, yes, I see. mitmproxy/mitmproxy#4033

commented

mitmproxy addon is now working and available for install!

Please consider it beta at the moment. There are a few more weirdities that I need to work out, but do submit issues to the issue tracker on the repo linked below.

https://my.home-assistant.io/redirect/_change/?redirect=supervisor_add_addon_repository%2F%3Frepository_url%3Dhttps%253A%252F%252Fgithub.com%252Fdavet2001%252Fhome-assistant-addons