Plume-org / Plume

Federated blogging application, thanks to ActivityPub (now on https://git.joinplu.me/ — this is just a mirror)

Home Page:https://joinplu.me

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Reply to Mastodon user will not showed as reply in Mastodon

pullopen opened this issue · comments

Plume works fine with the federation between Plume and Mastodon, which is its advantage to other blog platform. However, when a mastodon user comments on an article from mastodon, and then if the plume user replies to this comment on plume, on mastodon it will not show as an reply, but as an original toot, with a full @username@mastodon.domain as plain text. It does not form as a complete "mention".

  • Plume version: 0.6.1-dev
  • Operating system: Windows
  • Web Browser: Firefox

I don't know Plumes whole behavior. So I cannot determine this is a bug or what is just not implemented. I need investigate but it might take a while.

Can you write actual Plume and Mastodon accounts?

Perhaps this is related to https://git.joinplu.me/Plume/Plume/issues/865

Can you write actual Plume and Mastodon accounts?

Perhaps this is related to https://git.joinplu.me/Plume/Plume/issues/865

Well, for example, the article here:

https://plume.pullopen.xyz/~/%E5%9B%BE%E4%B9%A6%E9%A6%86%E7%AE%A1%E7%90%86%E6%97%A5%E5%BF%97/plume-%E6%9B%B4-%E6%96%B0-%E8%87%B3-0.5.0-%E5%90%8E-%E7%9A%84-%E6%B5%8B-%E8%AF%95-%E7%BB%93-%E6%9E%9C

The plume account made an reply to mastodon account @flyover@pullopen.xyz on Plume, but on mastodon it shows like this:

https://pullopen.xyz/@flyover/105394047400463952

The reply below did not make a valid "mention" to the mastodon account.

Thanks for the explanation. Let me clear. For me, both on Plume and Mastodon, admin@plume.pullopen.xyz replies flyover@pullopen.xyz that "然而刚夸完站就挂了……".

Could you explain more details, please?

Thanks for the explanation. Let me clear. For me, both on Plume and Mastodon, admin@plume.pullopen.xyz replies flyover@pullopen.xyz that "然而刚夸完站就挂了……".

Could you explain more details, please?

Yes, but in mastodon, the @flyover@pullopen.xyz is just a plain text. It's not a valid "mention" and you can not get notification from it on mastodon.

Ah, I understood. Okay, I will investigate it. Thank you for reporting.

At v0.7.0, actually commenting doesn't include mention links: https://git.joinplu.me/Plume/Plume/src/tag/0.7.0/src/routes/comments.rs#L73-L83

            for ment in mentions {
                Mention::from_activity(
                    &conn,
                    &Mention::build_activity(&conn, &ment)
                        .expect("comments::create: build mention error"),
                    comm.id,
                    false,
                    true,
                )
                .expect("comments::create: mention save error");
            }

These mentions should be included in comment activity.

I was wrong. Mentions in a comment are attached here: https://git.joinplu.me/Plume/Plume/src/tag/0.7.0/plume-models/src/comments.rs#L135-L139

I just tried in v0.7.3-dev. Now the username mentioned in plume will show as a link in mastodon now (which will even have a link preview) rather than plain text. However I still can not receive any notification in mastodon. Anyway it looks better though.