Dist.h exposes too many internal details and lacks unit tests.
alexisbarraza3293 opened this issue · comments
Alexis Barraza commented
The contents of dist.h/dist.cc should be encapsulated into a class and conformed to standard C++ randomization and organize the interface to hide implementation details from the user. The files also need a unit test to ensure all the functions operate as intended.
John Ousterhout commented
Does the pull request from last month deal with all these issues (i.e. can this issue be closed?)?
Alexis Barraza commented
Yes, I will close the issue