PlatformLab / HomaModule

A Linux kernel module that implements the Homa transport protocol.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Dist.h exposes too many internal details and lacks unit tests.

alexisbarraza3293 opened this issue · comments

The contents of dist.h/dist.cc should be encapsulated into a class and conformed to standard C++ randomization and organize the interface to hide implementation details from the user. The files also need a unit test to ensure all the functions operate as intended.

Does the pull request from last month deal with all these issues (i.e. can this issue be closed?)?

Yes, I will close the issue