PiranhaCMS / piranha.core

Piranha CMS is the friendly editor-focused CMS for .NET that can be used both as an integrated CMS or as a headless API.

Home Page:http://piranhacms.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade TinyMCE to 6.7.0?

hellfirehd opened this issue · comments

Are there any plans to upgrade TinyMCE to v6.7.0?

In my own experimenting, It looks like the piranhaimage and piranhalink plugins will work without any modifications. The only significant changes are to:

  • _EditorConfig.cshtml - supply an array instead of a string:
- this.plugins = "@EditorConfig.Current.Plugins";
+ this.plugins = @EditorConfig.Current.Plugins();
  • An extension method to convert editorconfig.json plugins to an array:
public static IHtmlContent Plugins(this EditorConfig config)
{
  var plugins = config.Plugins.Split(' ', StringSplitOptions.TrimEntries | StringSplitOptions.RemoveEmptyEntries);
  return new HtmlContentBuilder().AppendHtml(JsonConvert.SerializeObject(plugins));
}

Also, TinyMCE v6.7.0 no longer includes jquery.tinymce.min.js but this does not appear to be used by PiranhaCMS.

Thoughts?

Hi there! We will definitely look into this for the next upcoming major which is planned for .NET 8

This didn't make it in version 11.0, but we'll look at the version available together with possible changes in the open source license.