The smoke testing is broken for any route containing a placeholder

Question

The smoke testing is broken for any route containing a placeholder

stof opened this issue 2 years ago · comments

Christophe Coevoet commented 2 years ago

The trait testing all routes is sending a request to $route->getPath(). this is flawed as $route->getPath() is not the URL corresponding to that route (the only case where it is the URL is for static routes).

Christophe Coevoet · Answer 1 · Sat Sep 17 2022 17:53:19 GMT+0800 (China Standard Time)

If you intentionally support only static routes for now, I suggest making that explicit:

rename SmokeTestAllRoutes to SmokeTestStaticRoutes
filter the data provider to only provide the static routes

Alex Rock · Answer 2 · Sat Sep 17 2022 19:47:05 GMT+0800 (China Standard Time)

Your proposal is the best one, since I don't think there is a proper way to test non-static routes without a clear view on what can be injected.

I will make the changes 👍

Alex Rock · Answer 3 · Mon Sep 19 2022 06:11:09 GMT+0800 (China Standard Time)

Fixed in latest commits, will publish a new tag and update documentation later 👍

Alex Rock · Answer 4 · Mon Sep 19 2022 06:18:25 GMT+0800 (China Standard Time)

With the latest update, any route for which all dynamic parameters have a default will also be tested, since they can be considered as static too.

Let's close for now, feel free to reopen if anything goes wrong on this particular subject!