PhenX / wikiwym

Automatically exported from code.google.com/p/wikiwym

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

blockquote-handling blocks break {{{ }}} blocks

GoogleCodeExporter opened this issue · comments

Reminder to self:

// these break {{{ }}} blocks:
//[/\n +(.*?)\n/gi, '<blockquote>$1</blockquote>'],
//[/\n{2,}(.*?)/gi, '<p>$1</p>']

with those regexes, each indented line inside a {{{ }}} block is wrapped in 
a BLOCKQUOTE tag. i have removed them from my copy because i consider {{{ 
}}} to be more important than proper blockquoting. i think the real 
solution is to eventually develop a recursive-descent or PEG-based parser 
instead of using regexes. (i have a good deal of experience with writing 
such parsers in C/C++, but i was hoping to avoid having to write a parser 
in JS.)


Original issue reported on code.google.com by sgbeal@googlemail.com on 20 Apr 2010 at 4:31

TODO? Add blockquote support to the GoogleCodeWikiParser bits.

Original comment by sgbeal@googlemail.com on 21 Apr 2010 at 10:12

This isn't broken in the current code (at least, as not as far as i have 
determined).

Original comment by sgbeal@googlemail.com on 22 Apr 2010 at 12:28

  • Changed state: Fixed

Original comment by sgbeal@googlemail.com on 21 Apr 2010 at 9:22

  • Changed state: Accepted