Completeness of Artificial Harmonics
cwitkowitz opened this issue · comments
Based on the current models for the artificial harmonics, I am wondering if TappedHarmonic, PinchHarmonic, and SemiHarmonic should be inheriting from ArtificialHarmonic instead of HarmonicEffect? Otherwise, I think the data for these classes may be incomplete, but I could be wrong.
Hey @cwitkowitz! No, I don't think these three should inherit from ArtificialHarmonic. HarmonicEffect is an abstract class that is made specific by the concrete types of harmonics, including NaturalHarmonic. In particular, ArtificialHarmonic has information about the pitch and the octave of the harmonic, and this info is missing from TappedHarmonic, PinchHarmonic, and SemiHarmonic.
