Artistic classnames don't match meta spec

Question

Artistic classnames don't match meta spec

Leont opened this issue 11 years ago · comments

The classnames of Software::License::Artistic_1_0 and Software::License::Artistic_2_0 don't match with the CPAN::Meta::Spec 2.0 entries artistic_1 and artistic_2. This confuses Module::Build.

Should they match? The fact that the rest does suggests this is the case, as does the logic in guess_license_from_meta, but this isn't explicitly state anywhere.

Karen Etheridge · Answer 1 · Fri Jan 17 2014 07:56:08 GMT+0800 (China Standard Time)

If they are supposed to match, it would be good to add a unit test that runs through all the names known to the spec to make sure that they stay matched.

Magnolia.K · Answer 2 · Sun Jan 26 2014 20:56:38 GMT+0800 (China Standard Time)

I think that a good solution is adding an alias Modules.

https://github.com/magnolia-k/Software-License/commit/a0ac1ac9d63951e13ee62016b2bc8943b7efa2b6

Magnolia.K · Answer 3 · Mon Jan 27 2014 19:25:39 GMT+0800 (China Standard Time)

I wrote 'use parent version'.

https://github.com/magnolia-k/Software-License/commit/67d6187418710ea11ea44ee1b71fbf481184d912

Ricardo Signes · Answer 4 · Fri Feb 21 2014 11:18:21 GMT+0800 (China Standard Time)

I did what we discussed and added guess_license_from_meta_key.