Success check in M2MNsdlInterface::create_nsdl_list_structure() checks only success of last call to create_nsdl_structure()

Question

Success check in M2MNsdlInterface::create_nsdl_list_structure() checks only success of last call to create_nsdl_structure()

markus-becker-tridonic-com opened this issue 6 years ago · comments

success is assigned multiple times at
https://github.com/ARMmbed/mbed-cloud-client/blob/9b0bc6a2f3f1f5dbb5be1827db83004d531b99c9/mbed-client/source/m2mnsdlinterface.cpp#L375

There is no early return on fail. Thus only the last assignment will be returned. This assumes that all following calls after an initial fail will always fail. Was not the case in our codebase.

Markus Becker · Answer 1 · Mon Aug 13 2018 20:26:19 GMT+0800 (China Standard Time)

FYI: @MarceloSalazar @karsev

ARM mbed CI · Answer 2 · Mon Aug 13 2018 23:54:34 GMT+0800 (China Standard Time)

ARM Internal Ref: IOTCLT-2906

Antti Yli-Tokola · Answer 3 · Wed Aug 15 2018 18:59:45 GMT+0800 (China Standard Time)

Thanks for your report. This has now been fixed and the change will be available in next release.