Clone impl for Broadcaster

Question

Clone impl for Broadcaster

simon-bourne opened this issue 2 years ago · comments

Simon Bourne commented 2 years ago

Is there any reason why Clone isn't implemented for Broadcaster?

Pauan · Answer 1 · Thu Jan 13 2022 00:14:51 GMT+0800 (China Standard Time)

I don't think there's any particular reason, it just hasn't been done yet.

Simon Bourne · Answer 2 · Thu Jan 13 2022 00:32:12 GMT+0800 (China Standard Time)

Great, it looked like it'd be easy to add as it's just an Arc inside, and the implementations of Broadcaster::signal* looked like they'd work on a clone of the Arc, but wanted to check. Would you take a pull request?

Pauan · Answer 3 · Thu Jan 13 2022 02:30:41 GMT+0800 (China Standard Time)

Thanks for the offer, but I already implemented it, it'll be in the next release.

Simon Bourne · Answer 4 · Thu Jan 13 2022 02:38:36 GMT+0800 (China Standard Time)

Even better, thanks!

Pauan · Answer 5 · Thu May 12 2022 02:11:11 GMT+0800 (China Standard Time)

This was released in version 0.3.25