Change serde to be optional again
Pauan opened this issue · comments
I think this issue can be closed
serde hasn't been made optional, because that's a breaking change.
The Cargo.toml appears to say otherwise. Is disabling the serde feature by default the breaking change?
Yes, default features are always applied, so they're effectively required.
Even if you try to use default-features = false, it doesn't really work. In order for default-features = false to work, every dependency has to use it. If even one dependency doesn't use it, then it won't work.
For example, dominator has a dependency on futures-signals. If you use dominator and futures-signals, then even if you use default-features = false, it won't work, because dominator isn't using default-features = false.
This means that default-features = false is pretty much always useless and does nothing. So in practice default features are always mandatory.