[FEATURE] Allow all keyword arguments of the figure object in `plot()`
mosc9575 opened this issue · comments
Starting form this post in SO it looks like only a few and not all keyword arguments of the figure object are evaluated in pandas_bokeh.plot().
This has some disatvantages and the UX can be improved.
Saying this it would be really nice if a user can set the width and height and is not foreced to the defaults.
Hi @mosc9575,
let me first thank your for your issue.
When I started the project I tried to replicate the matplotlib implementation of Pandas plotting API (https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.plot.html). One can argue if this turned out to be a good starting point, however I tried to mimic the basics as perfect as possible.
This of course is in stark contrast to your request, that you can pass figure keyword arguments to the plot API. If you think one step further, why should the plotting API respect the API from the bokeh.figure object, one could argue if it shouldn't accept the keyword arguments of the corresponding glyph (line, rect, etc.). I hope you get the point ;)
Therefore, I would like to close the requests, because I don't think that mixing the pandas.plotting API with bokeh.figure will be the right step. Especially when setting the width and height is as easy as using the figsize argument (see https://github.com/PatrikHlobil/Pandas-Bokeh#advanced-lineplot).
Best Patrik
Your explenation sounds very logical. If you want to close this issue please go ahaed, I am fine with it.