Rework dev bundle patch generation to not use GNU diff

Question

Rework dev bundle patch generation to not use GNU diff

jpenilla opened this issue 3 years ago · comments

This is generally not very high priority as most of the time dev bundles will be generated by CI and published to maven, but it would be nice to not need GNU diff for dev bundle generation, for easier local testing on macOS (for those who for some reason don't install GNU coreutils) and Windows.

Two possible alternatives are

Using git to generate the patches (looked into briefly before and didn't have much luck, but I was probably missing something obvious)
Using Diff4j/Diffpatch/something else to generate the patches

Maroš Prejsa · Answer 1 · Tue Mar 15 2022 21:44:37 GMT+0800 (China Standard Time)

GNU DiffUtils does not have --color option. This should be marked as bug, not an "enhancement".

MiniDigger | Martin · Answer 2 · Tue Mar 15 2022 22:11:59 GMT+0800 (China Standard Time)

GNU DiffUtils does not have --color option. This should be marked as bug, not an "enhancement".

thats wrong https://www.gnu.org/software/diffutils/manual/diffutils.html#index-color_002c-distinguishing-different-context

Maroš Prejsa · Answer 3 · Tue Mar 15 2022 23:13:08 GMT+0800 (China Standard Time)

It's not available in prebuilt version 2.8.

Alexander Brandes · Answer 4 · Tue Mar 15 2022 23:46:01 GMT+0800 (China Standard Time)

In 10 days, 2.8 celebrates 20th anniversary. --color was originally introduced in 3.4, but you should update to the newest release from a few months ago; 3.8.
However, I'm currently on 3.7 and it works out of the box as well.

Maroš Prejsa · Answer 5 · Wed Mar 16 2022 01:48:41 GMT+0800 (China Standard Time)

It's not available standalone, after installing pacman I finally managed to get it.