PaperMC / Velocity

The modern, next-generation Minecraft server proxy.

Home Page:https://papermc.io/software/velocity

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add send packet `PacketPlayInResourcePackStatus` if already loaded resourcepack

code-lime opened this issue · comments

commented

In #1236 removed update resourcepack on client if its already loaded, but velocity dont send packet PacketPlayInResourcePackStatus with status SUCCESSFULLY_LOADED to server

62c6ec0 - isn't that what was resolved here?

commented

Current velocity version:

[com.velocitypowered.proxy.VelocityServer]: Booting up Velocity 3.3.0-SNAPSHOT (git-75d6dcc1-b371)...

Trace packet with resourcepack status from player

--FIRST CONNECTION--
p1-gpo-dev  | [15:08:14 INFO]: UUID of player Code_Lime is ce6e763f-a669-40eb-866d-019e6ddca12c
p1-gpo-dev  | [15:08:14 WARN]: [LIME:P1] Send resourcepack to Code_Lime with hash: 9cfe4273590e1ded581ee6f8dfc1bef4e41188a9
p1-gpo-dev  | [15:08:14 INFO]: Code_Lime[/46.53.242.197:60560] logged in with entity id 20800 at ([world]-949.549127115524, 80.0, 882.9852149595778)
p1-gpo-dev  | [15:08:14 WARN]: [LIME:P1] ResourcePack status packet from Code_Lime: ACCEPTED
p1-gpo-dev  | [15:08:19 WARN]: [LIME:P1] ResourcePack status packet from Code_Lime: SUCCESSFULLY_LOADED

p1-gpo-dev  | [15:08:27 INFO]: Code_Lime lost connection: Disconnected

--SECOND CONNECTION FROM HUB--
p1-gpo-dev  | [15:08:31 INFO]: UUID of player Code_Lime is ce6e763f-a669-40eb-866d-019e6ddca12c
p1-gpo-dev  | [15:08:31 WARN]: [LIME:P1] Send resourcepack to Code_Lime with hash: 9cfe4273590e1ded581ee6f8dfc1bef4e41188a9
p1-gpo-dev  | [15:08:31 INFO]: Code_Lime[/46.53.242.197:50636] logged in with entity id 22311 at ([world]-951.7727661605458, 80.0, 882.896413843143)
p1-gpo-dev  | [15:08:31 WARN]: [LIME:P1] ResourcePack status packet from Code_Lime: ACCEPTED
commented

Packet error

--SECOND CONNECTION FROM HUB--
p1-gpo-dev  | [15:39:49 INFO]: UUID of player Code_Lime is ce6e763f-a669-40eb-866d-019e6ddca12c
p1-gpo-dev  | [15:39:49 WARN]: [LIME:P1] Send resourcepack to Code_Lime with hash: 9cfe4273590e1ded581ee6f8dfc1bef4e41188a9
p1-gpo-dev  | [15:39:49 INFO]: Code_Lime[/46.53.242.197:40026] logged in with entity id 152186 at ([world]-948.405957303345, 79.0, 876.8482398818709)
p1-gpo-dev  | [15:39:49 WARN]: [LIME:P1] ResourcePack status packet from Code_Lime: ACCEPTED
p1-gpo-dev  | [15:39:49 WARN]: [LIME:P1] ResourcePack status packet from Code_Lime: SUCCESSFULLY_LOADED
p1-gpo-dev  | [15:39:49 INFO]: Code_Lime lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.lang.ArrayIndexOutOfBoundsException: Index 4 out of bounds for length 4

serverConn.getConnection().write(new ResourcePackResponsePacket(
packet.getId(), packet.getHash(), PlayerResourcePackStatusEvent.Status.DOWNLOADED));

Paper not found enum value of PlayerResourcePackStatusEvent.Status.DOWNLOADED

Supported only:

  public enum EnumResourcePackStatus {
    SUCCESSFULLY_LOADED,
    DECLINED,
    FAILED_DOWNLOAD,
    ACCEPTED;
  }

server version?

commented

1.20.1