PUGX / badge-poser

The PHP badges, renders some badges for your readme with the packagist information.

Home Page:https://poser.pugx.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException: No route found for "OPTIONS /laravel/framework/license.svg": Method Not Allowed (Allow: GET)

sentry-io opened this issue · comments

Sentry Issue: BADGE-POSER-X

Symfony\Component\Routing\Exception\MethodNotAllowedException: 
  File "/public/index.php", line 25
    $response = $kernel->handle($request);
...
(7 additional frame(s) were not displayed)

Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException: No route found for "OPTIONS /laravel/framework/license.svg": Method Not Allowed (Allow: GET)
  File "/public/index.php", line 25
    $response = $kernel->handle($request);
...
(4 additional frame(s) were not displayed)

This is not a issue!

We could re-open this issue and fix it by excluding such errors from being logged

I set this type of error on sentry as ignore! ;)

Can't we, instead, configure our sentry client to not send it?

In my opinion it would not be correct, because we should configure to exclude all error for Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException and we may miss out on others potential future errors! On sentry we can choose to ignore that specific error!
You know?

@JellyBellyDev I think if you only ignore them on sentry they still count towards the quota (https://forum.sentry.io/t/ignoring-errors-and-plan-rate-limit/1361) so IMHO we should do as @garak suggested, maybe not simply blacklisting all MethodNotAllowedHttpExceptions.

The thread is 3 years old tho, maybe is worth to double-check.

Before ignoring it anyway I would understand who is making that OPTION request and if this is used on different domains, if so, do we want it? if we do we might just consider enabling CORS.

what's your take on this?

I don't think we have quota problems!
I analyzed the headers and referer of these requests and they are all unpleasant situations.
For me we can close it here! ;)