duplicate completions
AmjadHD opened this issue · comments
There are many duplicate completions, that I see no benefits of:
I think that a symbol should only be included once in the completion list, disambiguation is the role of signatureHelp.
Hmm, what should be shown in the right hand column then?
the module ?
Or show the number of overloads like clangd (which I don't prefer):
Well the overloads can live in different modules, so how would that work? I have implemented the number of overloads version for now, what do you think?
Well the overloads can live in different modules
Yeah, I realized that after I suggested it.
in the common case of one module, show the name else the number of modules.
That could work as well. I'll have a look at it later, but I'm closing this issue for now.
Oh wait, I hadn't closed the PR yet. This should be closed automatically when that is merged.