Is PHPC10 already running tests for PHP8.2 in the current dev version?
LukeWCS opened this issue · comments
Hello
I deleted the feature request template because it doesn't apply to my issue. And I don't want to report a bug either, I just want to ask a question for which I couldn't find any information.
From my modest knowledge of PHP, PHPC10 Dev runs a test for at least one thing, which involves ${var}. But I can't see if PHPC10 is running any more PHP 8.2 tests. The background of my question is that I use PHPC9 for PHP versions 5.3 - 7.4 and PHPC10 for PHP 8.0 and 8.1. My phpBB Ext Check service also has its own module for each PHP version from 5.3 - 8.1.
Can I already set up a test module for 8.2, or is the scope of testing of PHPC10 for PHP 8.2 still too small? I also run a test with 5.3-, which covers everything anyway. But we also check each PHP version separately so that we can immediately see in the report which PHP versions an ext is actually compatible with. This can only be done separately for each PHP version.
On a side note: GitHub Repos has had a forum function for some time. Wouldn't that be an option here for the PHPC repo as well? Because then you can ask questions without having to open an issue right away. Or would that be too much effort for you? I could understand that.
I deleted the feature request template because it doesn't apply to my issue.
That option is always available:
But I can't see if PHPC10 is running any more PHP 8.2 tests.
Sounds like you are looking for: #1348
The background of my question is that I use PHPC9 for PHP versions 5.3 - 7.4 and PHPC10 for PHP 8.0 and 8.1.
I'd recommend using PHPC10 for all checks as the pre-existing checks have been getting quite some improvements in PHPC 10 as well.
My phpBB Ext Check service also has its own module for each PHP version from 5.3 - 8.1.
...
But we also check each PHP version separately so that we can immediately see in the report which PHP versions an ext is actually compatible with.
Unless you control the server something is being run on, I'd suggest always running with the range of PHP versions which should be supported instead of one individual version.
Reason being that certain checks will only flag something on a range of PHP versions.
Think: the change in the default value for the $flags parameter for htmlspecialchars() et all.
This will only be flagged if code needs to support both PHP 8.0 or lower AND PHP 8.1 or higher.
Can I already set up a test module for 8.2, or is the scope of testing of PHPC10 for PHP 8.2 still too small?
Up to you. Not for me to say.
On a side note: GitHub Repos has had a forum function for some time. Wouldn't that be an option here for the PHPC repo as well?
With a low-issue-traffic repo like this, it would just scatter the information in yet more places, lowering the chance of people finding the answers themselves.
Sounds like you are looking for: #1348
Of course I know the ToDo list. But for me it has only limited significance about what PHPC10 actually checks, since my PHP knowledge is also limited. This applies in particular to PHPCS and PHPC, among others. ^^
I'd recommend using PHPC10 for all checks as the pre-existing checks have been getting quite some improvements in PHPC 10 as well.
Good point. Now that PHPC10 has received your recent optimizations in terms of performance, my previous argument for using PHPC9 and PHPC10 in parallel is no longer valid.
All right, then I'll switch completely to PHPC10 now.
Unless you control the server something is being run on, I'd suggest always running with the range of PHP versions which should be supported instead of one individual version.
The server on which PHPC is running is irrelevant regarding the PHP versions to be checked, since my analysis system checks phpBB extensions "neutrally". This means that the extensions are used on very different systems and must therefore be checked neutrally.
It may be that an extension is used under PHP 7, or under PHP 8 or that we generally have to check for which PHP versions an extension is generally suitable.
Reason being that certain checks will only flag something on a range of PHP versions.
Think: the change in the default value for the
$flagsparameter forhtmlspecialchars()et all. This will only be flagged if code needs to support both PHP 8.0 or lower AND PHP 8.1 or higher.
I'm aware of the differences between checking separate PHP versions and -5.3, you pointed this out to me a long time ago: #958 (comment)
However, that is not the point. It's difficult to convey that, because we use PHPC a little differently than it was probably intended.
With a low-issue-traffic repo like this, it would just scatter the information in yet more places, lowering the chance of people finding the answers themselves.
Understood.
Okay, that answers my questions so far, thanks Juliette.
I'd recommend using PHPC10 for all checks as the pre-existing checks have been getting quite some improvements in PHPC 10 as well.
Hi Juliette, just for info