PHPCompatibility / PHPCompatibility

PHP Compatibility check for PHP_CodeSniffer

http://techblog.wimgodden.be/tag/codesniffer/

__destruct visibility must not be declared as public

magikstm opened this issue a year ago · comments

magikstm commented a year ago

Bug Description

__destruct visibility may be private.

Ref: https://www.php.net/manual/en/language.oop5.magic.php

I'll provide a fix.

Given the following reproduction Scenario

Ref: mikecao/flight#481

I'd expect the following behaviour

No report of an error.

Instead this happened

There is an error reported.

Environment

Tested Against `develop` branch?

I have verified the issue still exists in the develop branch of PHPCompatibility.

Juliette commented a year ago

Confirmed: https://3v4l.org/IPG3Q#veol