PHPCompatibility / PHPCompatibility

PHP Compatibility check for PHP_CodeSniffer

Home Page:http://techblog.wimgodden.be/tag/codesniffer/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`eregDeprecated` sniff picks up method names

afilina opened this issue · comments

Bug Description

The following sniffs pick up method names in addition to function names, causing an error where it shouldn't:

  • eregDeprecatedRemoved
  • eregiDeprecatedRemoved
  • ereg_replaceDeprecatedRemoved
  • eregi_replaceDeprecatedRemoved

Given the following reproduction Scenario

The issue happens when running this command:

phpcs -ps file.php --standard=PHPCompatibility --runtime-set testVersion 8.1

... over a file containing this code:

MyClass::eregi($value, $string);

I'd expect the following behaviour

No errors or warnings.

Instead this happened

PHPCompatibility.Extensions.RemovedExtensions.eregDeprecatedRemoved

Environment

Environment Answer
PHP version 8.2.3
PHP_CodeSniffer version 3.7.2
PHPCompatibility version 9.3.5
Install type Composer project

Tested Against develop branch?

  • I have verified the issue still exists in the develop branch of PHPCompatibility.

@afilina This is a known issue and the RemovedExtensions sniff is slated to be removed before the PHPCompatibility 10.0.0 release because of it.

See #1022 for further details.

(sorry, will leave this issue open until #1022 has been finalized)